Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'private:' protocol in Firefox 37-43 and Pale Moon 27+ #248

Closed
wants to merge 1 commit into from
Closed

Fix 'private:' protocol in Firefox 37-43 and Pale Moon 27+ #248

wants to merge 1 commit into from

Conversation

JustOff
Copy link

@JustOff JustOff commented Feb 20, 2017

Resolves #247.

@Infocatcher
Copy link
Owner

Thanks a lot!
There is another possible failure:
newChannel(uri) -> newChannel2(uri, null)
https://github.com/Infocatcher/Private_Tab/blob/0.2.1.2/protocol.jsm#L73
https://github.com/Infocatcher/Private_Tab/blob/0.2.1.2/protocol.jsm#L88
So, I applied a bit different patch: 5df97c5
Anyway, I appreciate your contribution.

@JustOff
Copy link
Author

JustOff commented Feb 20, 2017

Thank you for fixing the problem!

PS: Would you mind add Pale Moon to install.rdf as target application explicitly? And considering the future end of support of legacy addons in Firefox it would be also nice to host Private Tab at https://addons.palemoon.org (I can assist you in this if needed).

@JustOff JustOff deleted the PR_protocolRedirect branch February 20, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustOff @Infocatcher