Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements for Indonesian (id) localization #79

Closed
Infocatcher opened this issue Jul 20, 2013 · 13 comments
Closed

Some improvements for Indonesian (id) localization #79

Infocatcher opened this issue Jul 20, 2013 · 13 comments
Labels
localization

Comments

@Infocatcher
Copy link
Owner

See https://addons.mozilla.org/addon/private-tab/reviews/491024/
(AMO doesn't support formatting and it's better to track this here)

  1. Translate accesskeys too (just like in Firefox localization):

    File menu

    (and in other menus)
  2. Context menu for links:

    Links context menu

    Something like Buka Tautan di Tab Mode Penjelajahan Pribadi Baru (just like built-in Buka Tautan di Jendela Mode Penjelajahan Pribadi Baru)?

    I don't know Indonesian, but translation should be in line with built-in translation, I think.
  3. Context menu for bookmarks:

    Bookmarks context menu

    Remove Link and uppercase Pribadi word?
  4. Context menu for tabs:

    Tabs context menu

    Uppercase Pribadi word?
  5. Also dialogCloseSingle=Tutup (&C) and dialogClose=Tutup saja (&C) may be changed to just &Tutup (but I don't know about Indonesian keyboard layout).
Infocatcher added a commit that referenced this issue Jul 20, 2013
@Infocatcher
Use Firefox translation for title modifier
aa43c87 
This is mainWindow.titlePrivateBrowsingSuffix from view-source:chrome://browser/locale/browser.dtd
(related to #79)
@DhannyNara
Copy link
Contributor

oh yeah, something wrong from my translation 😆
in there "Tab Mode Pribadi Baru (V) -> Tab Mode Pribadi Baru (P) [ V to P ]
Buka Link -> Buka Tautan

@Infocatcher
Copy link
Owner Author

V to P

Already used in
label="Pratinjau Cetak" accesskey="P"

@DhannyNara
Copy link
Contributor

okay, try another accesskey.
by the way, you can use
Tab Penjelajahan Pribadi (&V) -> Tab &Penjelajahan Pribadi
Tab Mode Pribadi Baru (V) set to Tab Mode &Pribadi Baru

dialogClose=Tutup saja (&C)
dialogRestore=Buat saja jadi &non-pribadi
set to
dialogClose=Tutup (&C)
dialogRestore=Buat jadi &non-pribadi
or
dialogClose=&Tutup
dialogRestore=Buat jadi &non-pribadi

@Infocatcher
Copy link
Owner Author

Already used too: label="Tab Baru" accesskey="T" and label="Bekerja Luring" accesskey="L".

May be "R" (Pribadi)? Seems like this key isn't used in all these menus.

@DhannyNara
Copy link
Contributor

but I think it already used too
label="Reload / Refresh " accesskey="R"
because when pressed R it refresh current page

@DhannyNara
Copy link
Contributor

Tab Mode Pribadi Baru (V) set to Tab Mode &Pribadi Baru

@DhannyNara
Copy link
Contributor

please change install.rdf from
<em:description>Tambahan tab penjelajahan pribadi</em:description>
set to
<em:description>Menambahkan mode tab penjelajahan pribadi</em:description>

@Infocatcher
Copy link
Owner Author

but I think it already used too
label="Reload / Refresh " accesskey="R"
because when pressed R it refresh current page

Some extension? Because I don't see such menu item.

please change "install.rdf"

I see your pull request #80, but
Menambahkan mode tab penjelajahan pribadi (you wrote here)
or
Menambahkan tab mode penjelajahan pribadi (in #80)
?

@DhannyNara
Copy link
Contributor

Menambahkan tab mode penjelajahan pribadi
i see that pic
see here

@DhannyNara
Copy link
Contributor

If another text use Mode Pribadi , use it
and if use Mode Penjelajahan Pribadi use it too

@Infocatcher
Copy link
Owner Author

OK, I merged #80, thanks.
Could you please create a pull request for locale/id/pt.properties?

Infocatcher added a commit that referenced this issue Jul 30, 2013
@Infocatcher
Some corrections for id locale:
d4fa1b3 
* based on https://github.com/daisukeDan/Private_Tab/commit/53a90887353ddaf49f36959d8d84770348c76a49
* use Upper Case in menus as in Firefox translation
* localize accesskeys
(#79)
@Infocatcher
Copy link
Owner Author

OK, I made some changes myself: d4fa1b3, based on my previous commentaries and your https://github.com/daisukeDan/Private_Tab/commit/53a90887353ddaf49f36959d8d84770348c76a49 (why you removed it? Something wrong or just a mistake?).

About "r" accesskey. I tested on Firefox 22.0 (with ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest/win32/xpi/id.xpi) on empty profile. And this accesskey looks unique. And first of all we should worry about conflicts with built-in accesskeys – it's impossible to find unique accesskey between many extensions.

@Infocatcher
Copy link
Owner Author

I added new localizable strings, see #101 (comment) (also updated on babelzilla).
And now you can subscribe to above issue to receive notifications about future changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
localization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Infocatcher @DhannyNara