Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the top-left Icon? #40

Open
kainsavage opened this issue Apr 22, 2013 · 4 comments
Open

Disable the top-left Icon? #40

kainsavage opened this issue Apr 22, 2013 · 4 comments

Comments

@kainsavage
Copy link

Is there a way to disable this programmatically?

I want to hide the fact that a tab is in private browsing mode, but I do not want to alter your addon (I use your addon's api directly from my extension).

EDIT: It would also be nice to have the ability to disable the underlining on a private tab.

@Infocatcher
Copy link
Owner

Oh, many things to change...
This is built-in browser styles for #main-window[privatebrowsingmode="temporary"] + "titlemodifier" attribute on the same root node.
And "privateTab-isPrivate" on tabs, which should be always here for nsISessionStore-related patches.

But may be possible (theoretically) to check for some tab attribute to show tab as not private.

@ssokolow
Copy link

@kainsavage If you do arrange a way, it'd probably be a good idea to make it optional. I value avoiding data loss more than perfect HistoryBlock secrecy and I do periodically restart my browser to force unused tabs back to their unloaded state. (Both for memory reasons and to suspend their Javascript execution)

(I've actually made private tabs even more obvious using the privateTabOverlayIcon.css example so I can check them all at a glance)

@Infocatcher
Copy link
Owner

Here requested ability to leave only underline on private tabs: http://forums.mozillazine.org/viewtopic.php?p=12830195#p12830195

Infocatcher added a commit that referenced this issue Dec 14, 2013
…s private

(to disable private window-like styles)
May be useful on Linux and with Australis on Windows
(related to #40)
@Infocatcher
Copy link
Owner

I added extensions.privateTab.usePrivateWindowStyle preference to not set "privatebrowsingmode" attribute (and disable private window-like styles). By default used old behavior.

Also this is easiest way to deal with

#main-window[privatebrowsingmode=temporary] #TabsToolbar::after {
  content: "";
  display: -moz-box;
  width: 40px;
  background: url("chrome://browser/skin/privatebrowsing-indicator.png") no-repeat center center;
}

from chrome://browser/skin/browser.css in Firefox 29.0a1 (at least on Windows 7).

Infocatcher added a commit that referenced this issue Dec 14, 2013
Infocatcher added a commit that referenced this issue Jan 6, 2014
Usage: #main-window[privateTab-selectedTabIsPrivate]
We currently have "usePrivateWindowStyle" preference, so this is an alternative for #main-window[privatebrowsingmode="temporary"]
(related to #40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants