-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to WebExtensions (aka compatibility with Firefox 57+) #254
Comments
See all the other open bugs about compatibility: https://github.com/Infocatcher/Private_Tab/issues?q=is%3Aissue+is%3Aopen+label%3Acompatibility @Infocatcher has devoted a lot of time on this, but Mozilla isn't cooperating. |
Any privilege is requirements more than https://github.com/mozilla/testpilot-containers/blob/master/webextension/manifest.json? |
Required API for private tabs or access to browser internals... |
OK, let's see: https://bugzilla.mozilla.org/show_bug.cgi?id=1358058
|
Interesting, thanks! Also "private containers" will solve issue about only one global private storage/container. |
And, probably, that's all. https://bugzilla.mozilla.org/show_bug.cgi?id=1358058#c12
|
Also to inherit private state of opener tab: |
Maybe a noob question (don't judge me I know nothing about coding 😫) - how come Brave has private tabs and it's based on Chromium/Blink? |
@bastadur That's a question you should ask the Brave developers. |
Some tests around WebExtensions: https://github.com/Infocatcher/Private_Tab_WE |
https://bugzilla.mozilla.org/show_bug.cgi?id=1354602 Still missing really private containers, but Not implemented: Also I not see any way to create configurable keyboard shortcuts, only hardcoded ones:
|
https://bugzilla.mozilla.org/show_bug.cgi?id=1303384 |
No easy way to inherit browser.tabs.insertRelatedAfterCurrent = true behavior, only ability to set tab position browser.tabs.create({
url: …,
cookieStoreId: …,
active: true,
index: …
}); No ability to inherit browser settings to open in active/background tab. |
Thanks! |
This one says that it can remove them automatically: https://addons.mozilla.org/addon/containers-on-the-go/ . It's a shame that its developer hasn't posted it on a public repository though. You could work together. You may get inspiration from this too: https://github.com/totallymike/contextPlus |
Тут много всего написано и не всё я понимаю. Можно резолюцию: есть перспективы у этого расширения для переезда на Firefox 57 или нет? |
@inoyakaigor никто пока не понимает. :) Но уже есть прототип https://github.com/Infocatcher/Private_Tab_WE |
Yes, that's easy (and now implemented), but the most important part is about private containers: https://bugzilla.mozilla.org/show_bug.cgi?id=1353726 or (and better) private flag for container itself. @inoyakaigor |
mozilla/multi-account-containers#47 Disable history per-container setting Edit: oh, already listed some posts above... |
From https://github.com/Infocatcher/Private_Tab_WE#issues
This can be implemented via Context Plus extension. |
As I see, this is only about const onClickedHandler = async function(info, tab) {
if (contextStore.hasOwnProperty(info.menuItemId)) {
const moveTab = !(info.modifiers && info.modifiers.includes("Ctrl"));
const cookieStoreId = contextStore[info.menuItemId];
const { active, index, pinned, url, windowId } = tab;
const newTabPromise = browser.tabs.create({
active,
cookieStoreId,
index: index + (moveTab ? 0 : 1),
pinned,
url,
windowId,
});
if (moveTab) {
await newTabPromise;
browser.tabs.remove(tab.id);
}
}
};
browser.contextMenus.onClicked.addListener(onClickedHandler); |
There's a new related extension: https://addons.mozilla.org/addon/temporary-containers/ https://github.com/stoically/firefox-add-on-temporary-containers/ Check it out and see the comment I've left on stoically/temporary-containers#17 |
Firefox 61 allows to interact with Tabs via WebExtension, is that any help? |
If you guys use the stable version of Firefox and are still interested in private tabs, I recommend this new lightweight extension: https://addons.mozilla.org/addon/open-in-temp-container/ . You need to go to the Firefox Add-ons Manager to see its options and make the toolbar button open new tabs. You can also give it permission to access your browsing history to prevent new URLs from being stored. |
As I'm sure you know, in November 2017, the Firefox 57 release will disable all addon APIs with the exception of the new WebExtensions API. Are there any plans for undertaking this transition, or auditing whether it is possible at all, or would require Mozilla extending the WebExtensions API to provide the necessary functionality?
The text was updated successfully, but these errors were encountered: