Simplify handleCommand()

(related to #99)
Infocatcher · Sep 13, 2013 · 546b0e5 · 546b0e5
1 parent ac5ef40
commit 546b0e5
Showing 1 changed file with 10 additions and 15 deletions.
diff --git a/bootstrap.js b/bootstrap.js
@@ -1469,21 +1469,16 @@ var windowsObserver = {
 	},
 	handleCommand: function(window, cmd, shifted, closeMenus, e) {
 		_log("handleCommand: " + cmd);
-		if(cmd == "openInNewPrivateTab")
-			this.openInNewPrivateTab(window, shifted);
-		else if(cmd == "openNewPrivateTab")
-			this.openNewPrivateTab(window);
-		else if(cmd == "toggleTabPrivate")
-			this.toggleContextTabPrivate(window, shifted);
-		else if(cmd == "openPlacesInNewPrivateTab")
-			this.openPlaceInNewPrivateTab(window, shifted, e);
-		else if(cmd == "openPlacesInPrivateTabs")
-			this.openPlacesInPrivateTabs(window, e, false);
-		else if(cmd == "openPlacesContainerInPrivateTabs")
-			this.openPlacesInPrivateTabs(window, e, true);
-		else {
-			var caller = Components.stack.caller;
-			throw new Error(LOG_PREFIX + 'Unknown command: "' + cmd + '"', caller.filename, caller.lineNumber);
+		switch(cmd) {
+			case "openInNewPrivateTab":              this.openInNewPrivateTab(window, shifted);         break;
+			case "openNewPrivateTab":                this.openNewPrivateTab(window);                    break;
+			case "toggleTabPrivate":                 this.toggleContextTabPrivate(window, shifted);     break;
+			case "openPlacesInNewPrivateTab":        this.openPlaceInNewPrivateTab(window, shifted, e); break;
+			case "openPlacesInPrivateTabs":          this.openPlacesInPrivateTabs(window, e, false);    break;
+			case "openPlacesContainerInPrivateTabs": this.openPlacesInPrivateTabs(window, e, true);     break;
+			default:
+				var caller = Components.stack.caller;
+				throw new Error(LOG_PREFIX + 'Unknown command: "' + cmd + '"', caller.filename, caller.lineNumber);
 		}
 	},
 	keypressHandler: function(e) {