Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: added OIDC error and edge-case handling #2708

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

misc: added OIDC error and edge-case handling #2708

wants to merge 3 commits into from
+85 −15

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Nov 8, 2024 •
edited
Loading

Description 📣

  • shows SMTP errors to the OIDC error callback page for immediate feedback
  • ensures that OIDC cannot be enabled when SMTP is not confirmed to be good
  • updates bootstrap SMTP check to display the actual error
  • ensures that user can login with OIDC if user account is previously created using org invite flow

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@sheensantoscapadngan sheensantoscapadngan marked this pull request as draft November 8, 2024 15:15
@sheensantoscapadngan sheensantoscapadngan marked this pull request as ready for review November 8, 2024 17:51
maidul98
maidul98 reviewed Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just left one comment

backend/src/ee/services/oidc/oidc-config-service.ts
const isSmtpConnected = await smtpService.verify();
if (!isSmtpConnected) {
throw new BadRequestError({
message: "Cannot enable OIDC when there are issues with the instance's SMTP configuration"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also suggest that they can turn on trust for OIDC in org settings to avoid this error?

maidul98
maidul98 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheensantoscapadngan @maidul98