Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more refactoring of ggcoefstats using insight #314

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

IndrajeetPatil
Copy link
Owner

No description provided.

@lintr-bot
Copy link

R/ggbarstats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:196:1: style: functions should have cyclomatic complexity of less than 15, this has 33.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:303:1: style: functions should have cyclomatic complexity of less than 15, this has 58.

ggcoefstats <- function(x,
^

R/ggcorrmat.R:167:1: style: functions should have cyclomatic complexity of less than 15, this has 30.

ggcorrmat <- function(data,
^

R/gghistostats.R:79:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

gghistostats <- function(data,
^

R/ggpiestats.R:110:1: style: functions should have cyclomatic complexity of less than 15, this has 22.

ggpiestats <- function(data,
^

R/ggscatterstats.R:96:1: style: functions should have cyclomatic complexity of less than 15, this has 34.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:63:1: style: functions should have cyclomatic complexity of less than 15, this has 31.

ggwithinstats <- function(data,
^

R/helpers_ggbetweenstats_graphics.R:369:26: style: %>% should always have a space before it and a new line after it, unless the full pipeline fits on one line.

​      ggsignif_xy(data %>% dplyr::pull({{ x }}), data %>% dplyr::pull({{ y }}))
                       ~~^

R/helpers_gghistostats_graphics.R:48:5: warning: local variable ‘label.value’ assigned but may not be used

label.value <- x_pos
    ^~~~~~~~~~~

1 similar comment
@lintr-bot
Copy link

R/ggbarstats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:196:1: style: functions should have cyclomatic complexity of less than 15, this has 33.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:303:1: style: functions should have cyclomatic complexity of less than 15, this has 58.

ggcoefstats <- function(x,
^

R/ggcorrmat.R:167:1: style: functions should have cyclomatic complexity of less than 15, this has 30.

ggcorrmat <- function(data,
^

R/gghistostats.R:79:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

gghistostats <- function(data,
^

R/ggpiestats.R:110:1: style: functions should have cyclomatic complexity of less than 15, this has 22.

ggpiestats <- function(data,
^

R/ggscatterstats.R:96:1: style: functions should have cyclomatic complexity of less than 15, this has 34.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:63:1: style: functions should have cyclomatic complexity of less than 15, this has 31.

ggwithinstats <- function(data,
^

R/helpers_ggbetweenstats_graphics.R:369:26: style: %>% should always have a space before it and a new line after it, unless the full pipeline fits on one line.

​      ggsignif_xy(data %>% dplyr::pull({{ x }}), data %>% dplyr::pull({{ y }}))
                       ~~^

R/helpers_gghistostats_graphics.R:48:5: warning: local variable ‘label.value’ assigned but may not be used

label.value <- x_pos
    ^~~~~~~~~~~

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #314   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     27           
  Lines        3289   3263   -26     
=====================================
- Hits         3289   3263   -26
Impacted Files Coverage Δ
R/grouped_ggbetweenstats.R 100% <ø> (ø) ⬆️
R/grouped_gghistostats.R 100% <ø> (ø) ⬆️
R/ggbetweenstats.R 100% <ø> (ø) ⬆️
R/ggcoefstats.R 100% <100%> (ø) ⬆️
R/helpers_ggbetweenstats_graphics.R 100% <100%> (ø) ⬆️

@lintr-bot
Copy link

R/ggbarstats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:196:1: style: functions should have cyclomatic complexity of less than 15, this has 33.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:303:1: style: functions should have cyclomatic complexity of less than 15, this has 58.

ggcoefstats <- function(x,
^

R/ggcorrmat.R:167:1: style: functions should have cyclomatic complexity of less than 15, this has 30.

ggcorrmat <- function(data,
^

R/gghistostats.R:79:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

gghistostats <- function(data,
^

R/ggpiestats.R:110:1: style: functions should have cyclomatic complexity of less than 15, this has 22.

ggpiestats <- function(data,
^

R/ggscatterstats.R:96:1: style: functions should have cyclomatic complexity of less than 15, this has 34.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:63:1: style: functions should have cyclomatic complexity of less than 15, this has 31.

ggwithinstats <- function(data,
^

R/helpers_ggbetweenstats_graphics.R:369:26: style: %>% should always have a space before it and a new line after it, unless the full pipeline fits on one line.

​      ggsignif_xy(data %>% dplyr::pull({{ x }}), data %>% dplyr::pull({{ y }}))
                       ~~^

R/helpers_gghistostats_graphics.R:48:5: warning: local variable ‘label.value’ assigned but may not be used

label.value <- x_pos
    ^~~~~~~~~~~

1 similar comment
@lintr-bot
Copy link

R/ggbarstats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:196:1: style: functions should have cyclomatic complexity of less than 15, this has 33.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:303:1: style: functions should have cyclomatic complexity of less than 15, this has 58.

ggcoefstats <- function(x,
^

R/ggcorrmat.R:167:1: style: functions should have cyclomatic complexity of less than 15, this has 30.

ggcorrmat <- function(data,
^

R/gghistostats.R:79:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

gghistostats <- function(data,
^

R/ggpiestats.R:110:1: style: functions should have cyclomatic complexity of less than 15, this has 22.

ggpiestats <- function(data,
^

R/ggscatterstats.R:96:1: style: functions should have cyclomatic complexity of less than 15, this has 34.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:63:1: style: functions should have cyclomatic complexity of less than 15, this has 31.

ggwithinstats <- function(data,
^

R/helpers_ggbetweenstats_graphics.R:369:26: style: %>% should always have a space before it and a new line after it, unless the full pipeline fits on one line.

​      ggsignif_xy(data %>% dplyr::pull({{ x }}), data %>% dplyr::pull({{ y }}))
                       ~~^

R/helpers_gghistostats_graphics.R:48:5: warning: local variable ‘label.value’ assigned but may not be used

label.value <- x_pos
    ^~~~~~~~~~~

@IndrajeetPatil IndrajeetPatil merged commit 808e2e7 into master Sep 17, 2019
@IndrajeetPatil IndrajeetPatil deleted the ggcoef_insightification branch September 17, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants