Use ManuallyDrop better rather than StringToFree
#193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of storing string raw parts and re-creating them, we can use `ManuallyDrop<T>` instead. Also, various builders were dropping the term builder string parts, but not clearing the vec, so if they were incorrectly used multiple times, they would have deallocated the same memory multiple times. This also makes the fact that strings are being dropped more explicit (by calls to `ManuallyDrop::drop` rather than the implicit drop from `String::from_raw_parts`). This will let us use `compact_str` in these places in the future. This is an incremental change. Future commits will continue to improve upon this.
Indra-db
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing string raw parts and re-creating them, we can use
ManuallyDrop<T>instead.Also, various builders were dropping the term builder string parts, but not clearing the vec, so if they were incorrectly used multiple times, they would have deallocated the same memory multiple times.
This also makes the fact that strings are being dropped more explicit (by calls to
ManuallyDrop::droprather than the implicit drop fromString::from_raw_parts).This will let us use
compact_strin these places in the future.This is an incremental change. Future commits will continue to improve upon this.