fix: address feedback #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
TheTechmage
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Took a bit to wrap my head around what the changes were doing since there was a bit of refactor work going on. Overall, I like these changes and I love the simplification of the list comprehensions in didcomm_messaging/v1/messaging.py along with the clarification that we're looking at Public keys and not Secret keys in the tests.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some good feedback from @frostyfrog on PR #39.
Typos, clarifications, and bug fixes galore.
One of @frostyfrog's comments highlighted that kid was being inconsistently used and there was actually a subtle bug as a result. This should now have that fixed.