New dockerfile #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I no longer think the Alpine image is worth developing against. I really tried to get it to work with phantomjs, but there is a bug in phantomjs that does not allow it to work with alpine linux. The performance difference to run through the whole spec suite is marginal between the alpine and debian images. I'm leaving this branch around just in case we decide we might want to go back to alpine down the road. This branch works with the exception of phantomjs. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official rails docker image is deprecated and suggests to just create your own. I decided it would be best to base the image off ruby:2.3-alpine since docker for mac uses alpine as the host OS. This image has all the dependencies we need to install all the gems currently used in iqapp.
https://hub.docker.com/_/rails/