Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape on the new Signature creation modal exits without confirmation #463

Closed
dspruell-i01 opened this issue May 1, 2023 · 0 comments
Closed
Labels
enhancement threat-intel Issue originated from Threat Intel (TI) team

Comments

@dspruell-i01
Copy link

dspruell-i01 commented May 1, 2023

UI issue with quality of life impact. Hitting Escape key on the new Signature creation modal currently exits the modal without confirmation by user, flushing in progress rule edits and losing work.

It would be better to only allow the modal to be closed with an explicit action (hitting X in the corner, or a close/discard button), and it should have a confirmation dialog to the user.

Reproduce:

  1. Navigate to Signatures (/#!/yara_rules)
  2. Click Create Signature; Create Signature Artifact modal is rendered
  3. Start filling out form fields
  4. Hit Escape key while editing in field

This occurs on creation and edit dialogs.

@dspruell-i01 dspruell-i01 added the threat-intel Issue originated from Threat Intel (TI) team label May 31, 2023
dcuellar322 added a commit that referenced this issue Jan 25, 2024
battleoverflow added a commit that referenced this issue Jan 28, 2024
zh #24 #463 #465 - Escape confirmation, Confirmation for viewing revisions, ability to clear metadata field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement threat-intel Issue originated from Threat Intel (TI) team
Projects
None yet
Development

No branches or pull requests

2 participants