Carousel #105
Carousel #105
Conversation
sophielevens
commented
Mar 15, 2018
sophielevens
commented
- Created carousel component
- Solved browser compatibility issues
- Relates Feature: Avatar Carousel #53
src/elm/State.elm
Outdated
| init : Navigation.Location -> ( Model, Cmd Msg ) | ||
| init location = | ||
| let | ||
| model = | ||
| viewFromUrl location initModel | ||
| in | ||
| model ! [] | ||
| model ! [ begin () ] |
There was a problem hiding this comment.
Can we name this something more descriptive?
src/elm/Views/CreateAvatar.elm
Outdated
| [ div [ class "flex justify-center flex-column items-center" ] [ h1 [ class "f3 green avenir center ma0" ] [ text "My Stimmy friend" ], h2 [ class "ma0 avenir fw2 f4" ] [ text "Choose your avatar" ] ] | ||
| , div | ||
| [ class "db makecarousel mv2" ] | ||
| [ div [ class "carousel-cell br4" ] |
There was a problem hiding this comment.
How come these images are at different indentations?
src/elm/Views/CreateAvatar.elm
Outdated
| ] | ||
| [] | ||
| ] | ||
| , img |
There was a problem hiding this comment.
Can you abastract the image out into a component and map over it?
src/css/_custom.css
Outdated
| @@ -1,27 +1,52 @@ | |||
| .lh-f1 { | |||
| line-height: 56px; | |||
| line-height: 56px; | |||
There was a problem hiding this comment.
@sophielevens @maxgerber Can we all use prettier with 2 space indentation? This will make code reviewing easier!
relates #53
|
Please see the changes made @ivanmauricio @lucymk 🐱 |
| ] | ||
|
|
||
|
|
||
| avatarCaroCell : String -> Html Msg |
There was a problem hiding this comment.
@sophielevens @maxgerber Could you use this new component in createAvatar above? 🙏
src/elm/State.elm
Outdated
| @@ -24,13 +24,16 @@ initModel = | |||
| } | |||
|
|
|||
|
|
|||
| port begin : () -> Cmd msg | |||
There was a problem hiding this comment.
@sophielevens @maxgerber Can you make this name more declarative? Also could you make a Ports.elm and put all ports in there?
relates #53
