Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exception handler #888

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Added exception handler #888

merged 2 commits into from
Jan 14, 2021

Conversation

MekDrop
Copy link
Member

@MekDrop MekDrop commented Jan 10, 2021

This will help easier to figure out what a blank page really means.

Example screen:
image

P.S.: syntax exceptions are handled >= 7.0; 5.6 handles most others; If exception happens before logger initialization also would not be handled in such way.

@MekDrop MekDrop added the bug label Jan 10, 2021
@MekDrop MekDrop added this to the 1.4.3 milestone Jan 10, 2021
@MekDrop MekDrop requested review from skenow and fiammybe January 10, 2021 19:33
@todo
Copy link

todo bot commented Jan 10, 2021

Remove in version 1.4 - no occurrences in the core

* @todo Remove in version 1.4 - no occurrences in the core
*/
public function activate($showErrors = false) {
icms_core_Debug::setDeprecated('$this->activated = ', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
$this->activated = $showErrors;
}


This comment was generated by todo based on a todo comment in 7855fd6 in #888. cc @MekDrop.

@todo
Copy link

todo bot commented Jan 10, 2021

Remove in version 1.4

* @todo Remove in version 1.4
*/
public function dumpAll() {
icms_core_Debug::setDeprecated('$this->dump("")', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
return $this->dump( '' );
}


This comment was generated by todo based on a todo comment in 7855fd6 in #888. cc @MekDrop.

@todo
Copy link

todo bot commented Jan 10, 2021

Remove in version 1.4

* @todo Remove in version 1.4
*/
public function dumpBlocks() {
icms_core_Debug::setDeprecated('$this->dump("blocks")', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
return $this->dump('blocks');
}


This comment was generated by todo based on a todo comment in 7855fd6 in #888. cc @MekDrop.

@todo
Copy link

todo bot commented Jan 10, 2021

Remove in version 1.4

* @todo Remove in version 1.4
*/
public function dumpExtra() {
icms_core_Debug::setDeprecated('$this->dump("extra")', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
return $this->dump('extra');
}


This comment was generated by todo based on a todo comment in 7855fd6 in #888. cc @MekDrop.

@todo
Copy link

todo bot commented Jan 10, 2021

Remove in version 1.4

* @todo Remove in version 1.4
*/
public function dumpQueries() {
icms_core_Debug::setDeprecated('$this->dump("queries")', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
return $this->dump('queries');
}


This comment was generated by todo based on a todo comment in 7855fd6 in #888. cc @MekDrop.

@todo
Copy link

todo bot commented Jan 10, 2021

Remove in version 1.4

* @todo Remove in version 1.4
*/
public function dumpFilters() {
icms_core_Debug::setDeprecated('$this->dump("filters")', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
return $this->dump('filters');
}


This comment was generated by todo based on a todo comment in 7855fd6 in #888. cc @MekDrop.

@todo
Copy link

todo bot commented Jan 10, 2021

Remove in version 1.4 - no occurrences in the core

* @todo Remove in version 1.4 - no occurrences in the core
*/
public function renderErrors() {
icms_core_Debug::setDeprecated('$this->dump("errors")', sprintf(_CORE_REMOVE_IN_VERSION, '1.4'));
return $this->dump( 'errors' );
}


This comment was generated by todo based on a todo comment in 7855fd6 in #888. cc @MekDrop.

@fiammybe
Copy link
Member

Will this also catch the error messages that show the full path on the server?

@MekDrop
Copy link
Member Author

MekDrop commented Jan 14, 2021

I can't say that will work for all but for some - yes

@fiammybe fiammybe merged commit b3f84f3 into ImpressCMS:branches/impresscms_1.4 Jan 14, 2021
@MekDrop MekDrop deleted the improvement/added-exception-handler branch January 14, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants