Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sanitize database queries in installer #815

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

fiammybe
Copy link
Member

No description provided.

@fiammybe fiammybe requested a review from MekDrop November 26, 2020 21:41
@fiammybe fiammybe self-assigned this Nov 26, 2020
@fiammybe fiammybe added the bug label Nov 26, 2020
@fiammybe fiammybe added this to the 1.4.2 milestone Nov 26, 2020
@fiammybe fiammybe linked an issue Nov 26, 2020 that may be closed by this pull request
@fiammybe
Copy link
Member Author

This was found after investigation https://hackerone.com/reports/983710 by solov9ev

Copy link
Member

@MekDrop MekDrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found few small issues

htdocs/install/page_dbsettings.php Outdated Show resolved Hide resolved
htdocs/install/page_dbsettings.php Outdated Show resolved Hide resolved
… should disappear + some parts do not need quotes.
@fiammybe fiammybe requested a review from MekDrop November 26, 2020 21:52
@fiammybe fiammybe requested a review from MekDrop December 1, 2020 23:58
@MekDrop MekDrop merged commit e174e84 into branches/impresscms_1.4 Dec 2, 2020
@MekDrop MekDrop deleted the impresscms-814 branch December 2, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better sanitize database queries in installer
2 participants