Messengers fields from user settings where removed #746
Conversation
…d-messengers-fields-from-user-settings
…d-messengers-fields-from-user-settings
…d-messengers-fields-from-user-settings
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| $this->execute( | ||
| sprintf('ALTER TABLE %s ADD COLUMN `user_msnm` varchar(100) NOT NULL default \'\'', $this->prefix('users')) | ||
| ); | ||
| $this->execute( |
There was a problem hiding this comment.
Call to undeclared method \RemoveOldMessangersFromUserIfExists::execute
| */ | ||
| private function prefix(string $table): string | ||
| { | ||
| return \icms::getInstance()->get('db-connection-1')->prefix($table); |
There was a problem hiding this comment.
Call to undeclared method \icms::get
| $this->execute( | ||
| sprintf('ALTER TABLE %s ADD COLUMN `user_aim` varchar(18) NOT NULL default \'\'', $this->prefix('users')) | ||
| ); | ||
| $this->execute( |
There was a problem hiding this comment.
Call to undeclared method \RemoveOldMessangersFromUserIfExists::execute
| $this->execute( | ||
| sprintf('ALTER TABLE %s ADD COLUMN `user_yim` varchar(25) NOT NULL default \'\'', $this->prefix('users')) | ||
| ); | ||
| $this->execute( |
There was a problem hiding this comment.
Call to undeclared method \RemoveOldMessangersFromUserIfExists::execute
|
|
||
| protected function down(): void | ||
| { | ||
| $this->execute( |
There was a problem hiding this comment.
Call to undeclared method \RemoveOldMessangersFromUserIfExists::execute
|
|
||
| protected function down(): void | ||
| { | ||
| $this->execute( |
There was a problem hiding this comment.
Tabs must be used to indent lines; spaces are not allowed
| protected function down(): void | ||
| { | ||
| $this->execute( | ||
| sprintf('ALTER TABLE %s ADD COLUMN `user_msnm` varchar(100) NOT NULL default \'\'', $this->prefix('users')) |
There was a problem hiding this comment.
Tabs must be used to indent lines; spaces are not allowed
| $this->execute( | ||
| sprintf('ALTER TABLE %s ADD COLUMN `user_icq` varchar(15) NOT NULL default \'\'', $this->prefix('users')) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Tabs must be used to indent lines; spaces are not allowed
| * @return string | ||
| */ | ||
| private function prefix(string $table): string | ||
| { |
There was a problem hiding this comment.
Opening brace should be on the same line as the declaration
|
|
||
| class RemoveOldMessangersFromUserIfExists extends AbstractMigration | ||
| { | ||
| protected function up(): void |
There was a problem hiding this comment.
Avoid using short method names like RemoveOldMessangersFromUserIfExists::up(). The configured minimum method name length is 3.
MekDrop
deleted the
improvement/remove-old-messengers-fields-from-user-settings
branch
It seems messenger settings for user were previously removed from database but there were no migrations for that and fields were visible but no data were possible to edit. This pull request fixes that.