Use league/mime-type-detection for dealing with mimetype detection & deprecated icms_Utils #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiammybe
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ImpressCMS/ideas#22
From now system module doesn't have mimetypes editing section. This was some functionality that never worked as expected. Mimetype permission based on module maybe a good idea but current implementation was made a bit complex too what it really did and fully not worked as expected.
Resolves ImpressCMS/ideas#31
icms_Utilsis from now deprecated (marked to be removed in 2.1). league/mime-type-detection mime detection library should be used instead (same will be used in flysystem 2.0).