1.5.x php7+ #1430
Merged
1.5.x php7+ #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Table header links for sorting were missing the query parameters causing the page to redirect instead of sort
Date/Time values could be false instead of integer
$icmsModule becomes icms::$module $icmsModuleConfig becomes icms::$module->config
The database columns are created as integer data types and the filtering before insert/update was treating them as text, resulting in errors when sql_mode STRICT_TRANS_TABLES is in effect
skenow
removed
the
Don't merge yet
Saving general preferences resulted in an error because of the missing function icms_float which was only a wrapper for icms_currency
MekDrop
approved these changes
May 23, 2023
|
I will reidentify the version in a coming PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to ensure functionality on PHP7+ without errors