Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept token for valid users only #1115

Merged
merged 1 commit into from
Jan 2, 2022
Merged

Accept token for valid users only #1115

merged 1 commit into from
Jan 2, 2022

Conversation

skenow
Copy link
Contributor

@skenow skenow commented Dec 31, 2021

The token should be tied to the user session and not allow anonymous access to this form

fiammybe
fiammybe approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@fiammybe fiammybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward, but it has big implications for security. Nice!

@fiammybe fiammybe merged commit d11743c into ImpressCMS:branches/impresscms_1.4 Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiammybe fiammybe fiammybe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skenow @fiammybe