-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to update module #948
Comments
@skenow it looks like the 'fct' parameter is lost, and so the security settings throw back to the acp frontpage. |
skenow
added a commit
to skenow/impresscms
that referenced
this issue
Mar 27, 2021
Thanks for testing, @david.j
fiammybe
pushed a commit
that referenced
this issue
Mar 28, 2021
* Start by added filter types to all input filters * One more input filter type specification * Repairing line endings - not sure where they were converted * Changing case of true and false to prevent overwriting * Using current ICMS constants * Choosing to use strict filtering - additional filtering happens later Submodules will need to apply their own filtering * Sanitizing input variables in the image browser plugin * Filter input for the image browser plugin * Input filter for adsense submodule * Input filtering for avatars submodule * Input filtering for comments submodule * Input filtering for customtag submodule * Refined variable declaration - filtering was already applied. * Input filtering and stricter coding for groups submodule * Standard input for submodule mimetypes * Standard input filtering for submodule modulesadmin * Standard input filtering for submodule ratings * Standard input filter for submodule - smilies * Standard input filtering for submodule userrank * Added in $_POST filtering to admin entry point Fixes #948 Thanks for testing, @david.j
We can close this now - right @fiammybe ? |
That is correct, I tested it and now this works. I hadn't noticed the language file issue yes, so that is a nice catch as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I am unable to update modules (even the system module) in the latest version
To Reproduce
Steps to reproduce the behavior:
Expected behavior
the module update procedure starts, listing the different installs or inserts n theDB that are done
Server
The text was updated successfully, but these errors were encountered: