Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update module #948

Closed
fiammybe opened this issue Mar 24, 2021 · 3 comments · Fixed by #949
Closed

Unable to update module #948

fiammybe opened this issue Mar 24, 2021 · 3 comments · Fixed by #949
Assignees
Milestone

Comments

@fiammybe
Copy link
Member

Describe the bug

I am unable to update modules (even the system module) in the latest version

To Reproduce

Steps to reproduce the behavior:

  1. Go to the module list page (/modules/system/admin.php?fct=modulesadmin)
  2. Click on the update button next to a module
  3. on the new page, click on the 'update' button
  4. Nothing happens, return to acp home page

Expected behavior

the module update procedure starts, listing the different installs or inserts n theDB that are done

Server

  • PHP version: 7.4
  • PHP is 32/64bit: 64
  • HTTP Server : [Apache, nginx] Apache
  • HTTP Server version: 2.4
  • HTTP Server is 32/64 bit: 64
@fiammybe
Copy link
Member Author

@skenow it looks like the 'fct' parameter is lost, and so the security settings throw back to the acp frontpage.

skenow added a commit to skenow/impresscms that referenced this issue Mar 27, 2021
@fiammybe fiammybe linked a pull request Mar 28, 2021 that will close this issue
fiammybe pushed a commit that referenced this issue Mar 28, 2021
* Start by added filter types to all input filters

* One more input filter type specification

* Repairing line endings - not sure where they were converted

* Changing case of true and false to prevent overwriting

* Using current ICMS constants

* Choosing to use strict filtering - additional filtering happens later

Submodules will need to apply their own filtering

* Sanitizing input variables in the image browser plugin

* Filter input for the image browser plugin

* Input filter for adsense submodule

* Input filtering for avatars submodule

* Input filtering for comments submodule

* Input filtering for customtag submodule

* Refined variable declaration - filtering was already applied.

* Input filtering and stricter coding for groups submodule

* Standard input for submodule mimetypes

* Standard input filtering for submodule modulesadmin

* Standard input filtering for submodule ratings

* Standard input filter for submodule - smilies

* Standard input filtering for submodule userrank

* Added in $_POST filtering to admin entry point Fixes #948

Thanks for testing, @david.j
@skenow
Copy link
Contributor

skenow commented Apr 5, 2021

We can close this now - right @fiammybe ?

@fiammybe
Copy link
Member Author

That is correct, I tested it and now this works. I hadn't noticed the language file issue yes, so that is a nice catch as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants