Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of pandas #37

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Update to latest version of pandas #37

merged 2 commits into from
Nov 7, 2023

Conversation

tsmbland
Copy link
Member

@tsmbland tsmbland commented Nov 7, 2023

Fixing compatibility issues with the latest version of pandas. In particular, some of the tutorials were complaining when trying to sort DatetimeArray objects. The current version of pandas returns this object when selecting a unique values from a column of dates, and it doesn't have a sort method. I fixed the error by following the accepted answer here:
https://stackoverflow.com/questions/76592108/how-can-a-pandas-datetimearray-be-sorted

I have checked that the output is the same as before

I can't see any other errors when running the tests or tutorials

Close #31

@tsmbland tsmbland requested a review from dalonsoa November 7, 2023 14:02
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@tsmbland tsmbland merged commit f340546 into main Nov 7, 2023
21 checks passed
@tsmbland tsmbland deleted the pandas branch November 7, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with current pandas version
2 participants