Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model didn't save extensions #116

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Model didn't save extensions #116

merged 3 commits into from
Oct 15, 2024

Conversation

barneydobson
Copy link
Collaborator

  • Now it does
  • Added a test to demonstrate

@barneydobson barneydobson linked an issue Oct 15, 2024 that may be closed by this pull request
model needs an extension attribute so it can be saved #115
Closed
@barneydobson barneydobson requested a review from dalonsoa October 15, 2024 09:29
dalonsoa
dalonsoa approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barneydobson barneydobson merged commit 7a053a1 into main Oct 15, 2024
13 of 14 checks passed
@barneydobson barneydobson deleted the model-extension-attribute branch October 15, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsoa dalonsoa dalonsoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

model needs an extension attribute so it can be saved
2 participants
@barneydobson @dalonsoa