Enable customising orchestration #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extensions consist of two addresses: (1) 'extension_file' includes the address of a script for any decorations of existing nodes/arcs/models objects; (2) 'new_classes' includes the new node name and the associated script address. It is noted that only the folder address is provided rather than the exact script address.
…rcs/models objects
-Update model: -- Add custom orchestration -- Load/save the custom orchestration -Update model_extensions.py -- Remove custom orchestration (this is now simplified) - Update settings_saved.yaml -- Add custom orchestration
Closed
dalonsoa
requested changes
Sep 13, 2024
for not conflicting with test_tutorial.py
|
Thank you Diego! I've now reformatted the code to pass the test. However, I still get one failed, which I have no clue how to address. Any suggestions would be helpful. |
dalonsoa
approved these changes
Sep 16, 2024
Co-authored-by: Diego Alonso Álvarez <[email protected]>
barneydobson
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
I committed @dalonsoa 's suggestion since it passes.
Otherwise fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by Enable extensions (loader) #99, this PR only keeps the customisation of orchestration from the Enable customisation pull request #54, and bins else. Another
test_customise_orchestrationfunction has also been added intest_model.pywith an example ymal filetest_customise_orchestration_example.yaml.