Use set rather than list

Co-authored-by: Diego Alonso Álvarez <[email protected]>
ImperialCollegeLondon · Oct 9, 2024 · ce74892 · ce74892
1 parent 9be6ab8
commit ce74892
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/wsimod/nodes/storage.py b/wsimod/nodes/storage.py
@@ -612,7 +612,7 @@ def apply_overrides(self, overrides=Dict[str, Any]):
             overrides (Dict[str, Any]): Dict describing which parameters should
                 be overridden (keys) and new values (values). Defaults to {}.
         """
-        overwrite_params = [
+        overwrite_params = set([
             "length",
             "width",
             "velocity",
@@ -631,10 +631,10 @@ def apply_overrides(self, overrides=Dict[str, Any]):
             "muptPpar",
             "max_temp_lag",
             "max_phosphorus_lag",
-        ]
+        ])
 
-        for param in overwrite_params:
-            setattr(self, param, overrides.pop(param, getattr(self, param)))
+        for param in overwrite_params.intersection(overrides.keys()):
+            setattr(self, param, overrides.pop(param))
 
         if "area" in overrides.keys():
             print(