Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed no longer necessary pre-commit update workflow #73

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

jacobcook1995
Copy link
Collaborator

@jacobcook1995 jacobcook1995 commented Sep 6, 2022

Description

@dalonsoa pointed out pre-commit hook updates are handled automatically by the pre-commit-ci bot. As such the Github action to update them (defined in pre-commit_autoupdate.yml) is redundant. So this pull request removes the file, which helpfully also fixes issue #71.

Fixes #71

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov-commenter
Copy link

Codecov Report

Merging #73 (aab402e) into develop (109bc86) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #73   +/-   ##
========================================
  Coverage    75.86%   75.86%           
========================================
  Files            3        3           
  Lines           58       58           
========================================
  Hits            44       44           
  Misses          14       14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@jacobcook1995 jacobcook1995 merged commit 0baf019 into develop Sep 6, 2022
@jacobcook1995 jacobcook1995 deleted the feature/remove_unnecessary_action branch September 6, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging of pull requests created by GitHub-actions can't be done
3 participants