-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributor docs #499
Conversation
@vgro I've moved the files in. Now we need to review and adapt. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #499 +/- ##
========================================
Coverage 94.91% 94.91%
========================================
Files 70 70
Lines 3857 3857
========================================
Hits 3661 3661
Misses 196 196 ☔ View full report in Codecov by Sentry. |
I changed all the references from |
@TaranRallings and @jacobcook1995 Vivienne and I have been over this and updated for VE - can you have a look over the Development section updates. I've built the branch: https://virtual-ecosystem.readthedocs.io/en/498-update-contributor-documentation/ Ignore the "The design of the Virtual Ecosystem" section. That still needs work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holy! This development section looks great.
The only thing I noticed was that in Docstring style for the Virtual Ecosystem package
there is a flake8
reference that might now need updating to rufus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR is to update the contributor/developer docs to make them up to date and fit for an external audience.
Todo:
pyrealm
, which has a very similar contributor setup.pyrealm
docs forvirtual_ecosystem
Fixes #498
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks