Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributor docs #499

Merged
merged 17 commits into from
Jul 10, 2024
Merged

Conversation

davidorme
Copy link
Collaborator

@davidorme davidorme commented Jul 5, 2024

Description

This PR is to update the contributor/developer docs to make them up to date and fit for an external audience.

Todo:

  • Import similar and recently updated docs from pyrealm, which has a very similar contributor setup.
  • Add new docs to table of contents and add some basic tags on outdated or new content.
  • Fix build errors to allow docs to be review online.
  • Convert pyrealm docs for virtual_ecosystem
  • Review content of outdated files and delete or port to new files as required.
  • Fix up the table of contents to the revised content.

Fixes #498

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Jul 5, 2024 that may be closed by this pull request
@davidorme
Copy link
Collaborator Author

@vgro I've moved the files in. Now we need to review and adapt.

@davidorme davidorme added this to the Documentation system milestone Jul 5, 2024
@davidorme davidorme added the documentation Improvements or additions to documentation label Jul 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (63fceb6) to head (a0bceb2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #499   +/-   ##
========================================
  Coverage    94.91%   94.91%           
========================================
  Files           70       70           
  Lines         3857     3857           
========================================
  Hits          3661     3661           
  Misses         196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgro
Copy link
Collaborator

vgro commented Jul 8, 2024

I changed all the references from pyrealm to virtual_ecosystem and highlighted a few issues where I wasn't sure if that was still up to date.

@davidorme davidorme marked this pull request as ready for review July 9, 2024 08:56
@davidorme
Copy link
Collaborator Author

@TaranRallings and @jacobcook1995

Vivienne and I have been over this and updated for VE - can you have a look over the Development section updates. I've built the branch:

https://virtual-ecosystem.readthedocs.io/en/498-update-contributor-documentation/

Ignore the "The design of the Virtual Ecosystem" section. That still needs work.

Copy link
Collaborator

@TaranRallings TaranRallings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy! This development section looks great.

The only thing I noticed was that in Docstring style for the Virtual Ecosystem package there is a flake8 reference that might now need updating to rufus.

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidorme davidorme merged commit b077a59 into develop Jul 10, 2024
12 checks passed
@davidorme davidorme deleted the 498-update-contributor-documentation branch July 10, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contributor documentation
5 participants