Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a handful of now defunct constants and methods. #482

Merged

Conversation

TaranRallings
Copy link
Collaborator

Description

This removes a handful of constants and methods that were left over from my original implementation of energetics and mortality. These are no longer in use and so I've cleaned them out.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • [] Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@TaranRallings TaranRallings linked an issue Jul 2, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (48e4b0a) to head (c92e94b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #482      +/-   ##
===========================================
- Coverage    94.95%   94.91%   -0.04%     
===========================================
  Files           70       70              
  Lines         3886     3857      -29     
===========================================
- Hits          3690     3661      -29     
  Misses         196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Always good to do a bit of spring cleaning.

@TaranRallings TaranRallings merged commit 038de10 into develop Jul 3, 2024
12 checks passed
@TaranRallings TaranRallings deleted the 474-animal-remove-unused-functions-and-constants branch July 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animal - remove unused functions and constants
3 participants