-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indirect development in animals #450
Conversation
…ng_functional_group cohorts, and added a function to select functional groups by name..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a couple of comments on the print
statements.
Are all of those TODO
s here and there also being open as issues, so they can be tackled in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some tiny suggestions, but this looks good!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #450 +/- ##
===========================================
+ Coverage 94.61% 94.66% +0.05%
===========================================
Files 70 70
Lines 3750 3786 +36
===========================================
+ Hits 3548 3584 +36
Misses 202 202 ☔ View full report in Codecov by Sentry. |
Description
This includes a few changes to do with animals that undergo indirect developmental, proceeding through a metamorphic process where their functional group changes, such as from caterpillar to butterfly.
Included:
Animal traits for: development type (direct vs indirect), development status (adult vs larval), and the functional group that is produced by the current functional group through either birth or metamorphosis. This also adds a non-reproductive reproductive type for larval functional groups.
The main methods included are
metamorphose
andmetamorphose_community
, creating the change and processing the change over the entire community, respectively.Fixes # (issue)
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks