Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indirect development in animals #450

Merged
merged 19 commits into from
Jun 21, 2024
Merged

Conversation

TaranRallings
Copy link
Collaborator

Description

This includes a few changes to do with animals that undergo indirect developmental, proceeding through a metamorphic process where their functional group changes, such as from caterpillar to butterfly.

Included:
Animal traits for: development type (direct vs indirect), development status (adult vs larval), and the functional group that is produced by the current functional group through either birth or metamorphosis. This also adds a non-reproductive reproductive type for larval functional groups.

The main methods included are metamorphose and metamorphose_community, creating the change and processing the change over the entire community, respectively.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a couple of comments on the print statements.

Are all of those TODOs here and there also being open as issues, so they can be tackled in the future?

Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some tiny suggestions, but this looks good!

tests/models/animals/test_animal_communities.py Outdated Show resolved Hide resolved
tests/models/animals/test_functional_group.py Outdated Show resolved Hide resolved
virtual_ecosystem/models/animal/animal_communities.py Outdated Show resolved Hide resolved
virtual_ecosystem/models/animal/functional_group.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (efd0b7f) to head (653c175).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #450      +/-   ##
===========================================
+ Coverage    94.61%   94.66%   +0.05%     
===========================================
  Files           70       70              
  Lines         3750     3786      +36     
===========================================
+ Hits          3548     3584      +36     
  Misses         202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TaranRallings TaranRallings merged commit d7298af into develop Jun 21, 2024
12 checks passed
@TaranRallings TaranRallings deleted the feature/indirect_development branch June 21, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants