Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the jupyter kernelspec setup #429

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

davidorme
Copy link
Collaborator

@davidorme davidorme commented Jun 4, 2024

Description

This removes the ve_python3 specific kernel for jupyter and falls back to poetry run/shell setting the jupyter kernelspec to point to the active poetry venv for the project.

The tests below and RTD all work, showing this simplification works as expected:
https://virtual-ecosystem.readthedocs.io/en/427-simplify-the-jupyter-kernelspec-setup/

Closes #427

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@davidorme davidorme linked an issue Jun 4, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (0ccb1c7) to head (73686c6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #429   +/-   ##
========================================
  Coverage    94.60%   94.60%           
========================================
  Files           70       70           
  Lines         3744     3744           
========================================
  Hits          3542     3542           
  Misses         202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of minor queries.

docs/source/development/documentation/jupyter_notebooks.md Outdated Show resolved Hide resolved
docs/source/virtual_ecosystem/virtual_ecosystem_in_use.md Outdated Show resolved Hide resolved
@davidorme davidorme merged commit 1132d87 into develop Jun 5, 2024
9 checks passed
@davidorme davidorme deleted the 427-simplify-the-jupyter-kernelspec-setup branch June 5, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the jupyter-kernelspec setup
3 participants