Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add radiation input #423

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Feature/add radiation input #423

merged 4 commits into from
Jun 3, 2024

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented May 29, 2024

This PR adds top of canopy shortwave downward radiation to the dummy example data. I noticed that this is a required variable when I started testing ve_run with the mechanistic abiotic model. I also noticed that molar density of air and specific heat of air were calculated but not added to the data object, so I updated that. The model is still not running but I stopped here as priorities shifted towards completing the simple abiotic model.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 94.52%. Comparing base (5621b8d) to head (423134d).

Files Patch % Lines
...tion_scripts/topofcanopy_radiation_example_data.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #423      +/-   ##
===========================================
- Coverage    94.69%   94.52%   -0.17%     
===========================================
  Files           69       70       +1     
  Lines         3732     3744      +12     
===========================================
+ Hits          3534     3539       +5     
- Misses         198      205       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgro vgro requested a review from jacobcook1995 May 29, 2024 07:43
Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

@vgro vgro merged commit a9a6fb8 into develop Jun 3, 2024
9 checks passed
@vgro vgro deleted the feature/add_radiation_input branch June 3, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants