Add VS code settings.json file #42
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,22 @@ | ||
| { | ||
| "python.linting.pylintEnabled": true, | ||
| "python.linting.flake8Enabled": true, | ||
| "python.linting.mypyEnabled": true, | ||
| "python.linting.enabled": true, | ||
| "python.formatting.provider": "black", | ||
| "editor.formatOnSave": true, | ||
| "editor.rulers": [ | ||
| 88 | ||
| ], | ||
| "python.testing.unittestEnabled": false, | ||
jaideep777 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
There was a problem hiding this comment. This should be here, otherwise VSCode testing does not know what to use for tests. There was a problem hiding this comment. It still is set to |
||
| "python.testing.pytestEnabled": true, | ||
| "python.testing.pytestArgs": [ | ||
| "-s", | ||
| "tests", | ||
| // --no-cov needed so that breakpoints work: https://github.com/microsoft/vscode-python/issues/693 | ||
| "--no-cov" | ||
| ], | ||
| "workbench.editorAssociations": { | ||
| "*.ipynb": "jupyter-notebook" | ||
| }, | ||
| } | ||
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like
pylintisn't in thepoetrydev dependencies btw. Do we want to enable it or not?I suggest we either don't use this linter or add it to the dependencies.
@dalonsoa @davidorme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to use it - and it seems we want, right @davidorme - it should be in the dependency list, yes.