Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/energy balance init #357

Merged
merged 8 commits into from
Jan 9, 2024

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Jan 8, 2024

This PR adds the files for the energy balance submodule and the setup() of variables that are required for the energy balance. The setup is copied from the simple abiotic model and there is an open to do to make the handling of constants neater, I would like to leave this for now as we are still moving constants around. I also deleted a few unneccessary bits here and there.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@vgro vgro requested a review from jacobcook1995 January 8, 2024 16:03
Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobcook1995
Copy link
Collaborator

Only thing I might suggest is making the open TODO into a Github issue, basically so that the issue is recorded somewhere that other people check

@vgro vgro merged commit fd352c6 into feature/new_abiotic_model Jan 9, 2024
22 checks passed
@vgro vgro deleted the feature/energy_balance_init branch January 9, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants