Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old temperature and moisture dependance #325

Merged
merged 14 commits into from
Oct 9, 2023

Conversation

jacobcook1995
Copy link
Collaborator

Description

This PR removes a couple of functions that calculate the impact temperature and moisture have on soil processes, as they are not really relevant to the planned soil model. These are replaced by new functions to calculate the impact that temperature and soil water potential on specifically microbial rates.

I decided against removing the old moisture function entirely as this would involve changing how significant parts of the model works (e.g. sorption of organic matter to minerals). This change will instead come as part of a subsequent pull request that will make the model enzyme-explicit.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I cannot say much about the science but it all looks sensible to me.

Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Merging #325 (425331e) into develop (62f0612) will decrease coverage by 0.13%.
The diff coverage is 91.89%.

@@             Coverage Diff             @@
##           develop     #325      +/-   ##
===========================================
- Coverage    96.62%   96.50%   -0.13%     
===========================================
  Files           48       48              
  Lines         2400     2403       +3     
===========================================
  Hits          2319     2319              
- Misses          81       84       +3     
Files Coverage Δ
virtual_rainforest/models/litter/constants.py 100.00% <ø> (ø)
virtual_rainforest/models/litter/litter_model.py 100.00% <ø> (ø)
virtual_rainforest/models/litter/litter_pools.py 100.00% <ø> (ø)
virtual_rainforest/models/soil/constants.py 100.00% <100.00%> (ø)
virtual_rainforest/models/soil/soil_model.py 100.00% <ø> (ø)
virtual_rainforest/models/soil/carbon.py 95.94% <82.35%> (-4.06%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobcook1995 jacobcook1995 merged commit 8d826e7 into develop Oct 9, 2023
22 checks passed
@jacobcook1995 jacobcook1995 deleted the feature/clean_up branch October 9, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants