-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old temperature and moisture dependance #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I cannot say much about the science but it all looks sensible to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #325 +/- ##
===========================================
- Coverage 96.62% 96.50% -0.13%
===========================================
Files 48 48
Lines 2400 2403 +3
===========================================
Hits 2319 2319
- Misses 81 84 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
This PR removes a couple of functions that calculate the impact temperature and moisture have on soil processes, as they are not really relevant to the planned soil model. These are replaced by new functions to calculate the impact that temperature and soil water potential on specifically microbial rates.
I decided against removing the old moisture function entirely as this would involve changing how significant parts of the model works (e.g. sorption of organic matter to minerals). This change will instead come as part of a subsequent pull request that will make the model enzyme-explicit.
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks