Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update hydro model #283

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Feature/update hydro model #283

merged 2 commits into from
Aug 10, 2023

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Aug 10, 2023

After discussion the limitations of soil parameterizations, I decided to remove the vertical flow from the soil moisture update and only keep the function for a 'mean flow rate' with lots of warnings in the comments (potentially too many repetitions). We can find a solution later together with the soil and plant model.
I also simplified the code a little bit by calculating intermediate variables that are used several times at the start, and I corrected how available capacity is calculated (sum of layers rather than mean)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me!

@vgro vgro merged commit 9ad91f0 into develop Aug 10, 2023
@vgro vgro deleted the feature/update_hydro_model branch August 10, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants