-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a litter model #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got some minor queries/suggestions, but otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a lot to add to @alexdewar. LGTM
Codecov Report
@@ Coverage Diff @@
## develop #268 +/- ##
===========================================
+ Coverage 95.27% 95.54% +0.26%
===========================================
Files 43 47 +4
Lines 1778 1885 +107
===========================================
+ Hits 1694 1801 +107
Misses 84 84
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This pull request adds a litter model to the Virtual Rainforest. The purpose of this model is to handle the decomposition of complex biomass lying on or just under the forest floor.
I made this a separate model from the
soil
model for a couple of reasons:At the moment, the model only has two pools "above_ground_metabolic" and "above_ground_structural" which represent the fast and slow decomposing above ground litter, respectively. In future, below ground pools and wood pools will also be added. The model will also get quite a lot more complex when we add leaf chemistry in (lignin, N and P).
I originally planned to add links from this model to the soil model in, but I thought that pull request was already getting large enough, so decided to save that for a later pull request.
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks