Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix time_index #255

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix time_index #255

merged 1 commit into from
Jul 12, 2023

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Jul 12, 2023

There was an issue with the time_index as a coordinate only, we need it to be a dimension to be accessible by isel. I tried to add a 4th dimension but that caused problems, so as an intermediate solution I renamed the time dimension and create an issue.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@vgro vgro requested a review from jacobcook1995 July 12, 2023 14:12
@codecov-commenter
Copy link

Codecov Report

Merging #255 (c701ba3) into develop (202baad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #255   +/-   ##
========================================
  Coverage    95.08%   95.08%           
========================================
  Files           42       42           
  Lines         1708     1708           
========================================
  Hits          1624     1624           
  Misses          84       84           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgro vgro merged commit ce4e662 into develop Jul 12, 2023
@vgro vgro deleted the feature/fix_time_index branch July 12, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants