-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a particulate organic matter pool #253
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #253 +/- ##
===========================================
+ Coverage 95.04% 95.08% +0.04%
===========================================
Files 42 42
Lines 1694 1708 +14
===========================================
+ Hits 1610 1624 +14
Misses 84 84
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The only thing I noticed is that a lot of functions operate with float
which I guess assumes that this is the same across all grid cells. Are you planning on extending this to account for all cell_ids?
…l order is preserved
Description
This pull request adds an extra carbon pool to the soil carbon model. The pool added is the particulate organic matter (POM) pool. This pool is for organic matter that is too complex to be immediately taken up by microbes but that isn't protected through mineral association. The motivation for adding this pool is that the carbon transfers from litter to soil go to this pool, so adding it is a prerequisite for setting up a
litter
model/module.I've just added @vgro as a reviewer here, as this PR just extends existing functionality and doesn't really add anything novel, so I don't feel it needs a really thorough going over. If others want to add comments that's completely fine.
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks