Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated poetry to latest versions #252

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

jacobcook1995
Copy link
Collaborator

Description

The CI GitHub Action has a problem where occasionally a run will fail during the install dependancies step (see here). This generally seems to happen on Windows with python version 3.10.

This PR updates poetry to latest version in case this is a poetry bug which has already been patched out. If it isn't then we'll have to investigate further.

(Updating poetry from 1.2.2 to 1.5.1 seems to halve dependancy install times, so I think this change is worthwhile regardless of if it fixes the bug)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of minor version changes in quite a short space of time! Still - they've been deprecating a load of old pre 1.00 options and updating stuff! Seems fine to me.

@davidorme
Copy link
Collaborator

And it looks like one of those changes is explicitly updating to a 'modern' installer for packages.

@jacobcook1995 jacobcook1995 merged commit 1f4c7da into develop Jul 10, 2023
@jacobcook1995 jacobcook1995 deleted the bugfix/use_higher_poetry branch July 10, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants