Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced module order to be fixed based on config input #245

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

jacobcook1995
Copy link
Collaborator

Description

This pull request changes select_models to use a list rather than a set to find the non-duplicated model names. This means that the inputted order of models is preserved, so that models are always called in the order the user specifies them.

This doesn't fix the broader issue of how we should handle model ordering, where the information should be stored, etc. It does fix the issue of vr_run sometimes randomly stalling when a valid model order is entered.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@jacobcook1995 jacobcook1995 requested a review from vgro July 4, 2023 11:46
@codecov-commenter
Copy link

Codecov Report

Merging #245 (5b63306) into develop (1fe8e44) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #245      +/-   ##
===========================================
+ Coverage    95.37%   95.39%   +0.01%     
===========================================
  Files           42       42              
  Lines         1643     1650       +7     
===========================================
+ Hits          1567     1574       +7     
  Misses          76       76              
Impacted Files Coverage Δ
virtual_rainforest/main.py 84.09% <100.00%> (+1.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobcook1995 jacobcook1995 merged commit d9e1fd1 into develop Jul 4, 2023
@jacobcook1995 jacobcook1995 deleted the bug_fix/freeze_model_order branch July 4, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants