Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for generating dummy soil data #229

Merged
merged 11 commits into from
May 31, 2023

Conversation

jacobcook1995
Copy link
Collaborator

Description

This pull request adds a recipe for generating the dummy soil data file to the data recipes section of the docs. This is a way of storing the code to generate the dummy data files in the medium term, and will likely be superseded by instructions on how to generate appropriate data files containing real data eventually.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • [N/A] Tests added that prove fix is effective or that feature works

@jacobcook1995 jacobcook1995 requested a review from vgro May 31, 2023 07:19
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #229 (818f1d7) into develop (53c2dca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #229   +/-   ##
========================================
  Coverage    95.23%   95.23%           
========================================
  Files           36       36           
  Lines         1553     1553           
========================================
  Hits          1479     1479           
  Misses          74       74           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobcook1995
Copy link
Collaborator Author

Ahh sorry @vgro, just realised that I made the pull request with the remote branch a few commits behind my local branch. It doesn't affect any of the comments you made (which I still need to address), but the TODO's at the top of the file are addressed

@vgro
Copy link
Collaborator

vgro commented May 31, 2023

Ahh sorry @vgro, just realised that I made the pull request with the remote branch a few commits behind my local branch. It doesn't affect any of the comments you made (which I still need to address), but the TODO's at the top of the file are addressed

No worries. I think it looks overall good, just add a bit more text to explain the steps and variables, then I'm happy for you to merge.

@jacobcook1995 jacobcook1995 requested a review from vgro May 31, 2023 09:16
Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@jacobcook1995 jacobcook1995 merged commit 299e39b into develop May 31, 2023
@jacobcook1995 jacobcook1995 deleted the feature/dummy_soil_recipe branch May 31, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants