-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for generating dummy soil data #229
Conversation
…ready for some reason)
Codecov Report
@@ Coverage Diff @@
## develop #229 +/- ##
========================================
Coverage 95.23% 95.23%
========================================
Files 36 36
Lines 1553 1553
========================================
Hits 1479 1479
Misses 74 74 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ahh sorry @vgro, just realised that I made the pull request with the remote branch a few commits behind my local branch. It doesn't affect any of the comments you made (which I still need to address), but the TODO's at the top of the file are addressed |
No worries. I think it looks overall good, just add a bit more text to explain the steps and variables, then I'm happy for you to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
Description
This pull request adds a recipe for generating the dummy soil data file to the data recipes section of the docs. This is a way of storing the code to generate the dummy data files in the medium term, and will likely be superseded by instructions on how to generate appropriate data files containing real data eventually.
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks