-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update module overview #224
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #224 +/- ##
========================================
Coverage 95.18% 95.18%
========================================
Files 35 35
Lines 1494 1494
========================================
Hits 1422 1422
Misses 72 72 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Unfortunately, I also can't remember what we agreed on in terms of module vs model when referring to our respective sections of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. I'd go with model
, I think. We have a BaseModel and module is widely used in Python to talk about organisational units of code more widely.
This PR adds a description of the
abiotic_simple_model
to the module overview.I don't remember what we agreed regarding
module
/model
, I thought is wasmodel
but it is a bit mixed in this file. I am happy to make the changes with your ok.Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest