Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for dummy model and ERA5 land #220

Merged
merged 4 commits into from
May 19, 2023
Merged

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented May 17, 2023

Here, I updated the documentation for climate data downloading and pre-processing once more to make it work for our dummy model as discussed on Tuesday.

The grid is 9x9 cells of 90 m (which corresponds to 3 arcmin) with x/y coordinates and I added a time_index coordinate to test the looping over time in the abiotic_simple_model.

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, (though admittedly I have no experience of working with this type of data)

docs/source/data_recipes/CDS_toolbox_template.md Outdated Show resolved Hide resolved
docs/source/data_recipes/ERA5_preprocessing_example.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #220 (8130f70) into develop (2082a42) will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #220      +/-   ##
===========================================
+ Coverage    94.95%   95.12%   +0.16%     
===========================================
  Files           33       35       +2     
  Lines         1408     1476      +68     
===========================================
+ Hits          1337     1404      +67     
- Misses          71       72       +1     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - minor comments

@vgro vgro merged commit f3294ab into develop May 19, 2023
@vgro vgro deleted the feature/climate_dummy_data_doc branch May 19, 2023 09:44
@vgro vgro restored the feature/climate_dummy_data_doc branch May 19, 2023 09:57
@vgro vgro deleted the feature/climate_dummy_data_doc branch May 24, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants