-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated for dummy model and ERA5 land #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, (though admittedly I have no experience of working with this type of data)
Codecov Report
@@ Coverage Diff @@
## develop #220 +/- ##
===========================================
+ Coverage 94.95% 95.12% +0.16%
===========================================
Files 33 35 +2
Lines 1408 1476 +68
===========================================
+ Hits 1337 1404 +67
- Misses 71 72 +1 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - minor comments
Here, I updated the documentation for climate data downloading and pre-processing once more to make it work for our dummy model as discussed on Tuesday.
The grid is 9x9 cells of 90 m (which corresponds to 3 arcmin) with x/y coordinates and I added a
time_index
coordinate to test the looping over time in theabiotic_simple_model
.