Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixs for pint problem in docs build action #218

Merged
merged 1 commit into from
May 17, 2023

Conversation

jacobcook1995
Copy link
Collaborator

Description

It seems like pint have changed how they do typing, which caused documentation build failures. I have set intersphinx to read from an earlier version of the pint documentation to avoid this problem.

This will have to change in future if we update pint, but at the moment it seems like they are still trying to pin down their typing, so doesn't seem sensible to refactor the code at the moment.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@jacobcook1995 jacobcook1995 requested a review from vgro May 17, 2023 07:55
@codecov-commenter
Copy link

Codecov Report

Merging #218 (fa3b01d) into develop (a3a1800) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #218   +/-   ##
========================================
  Coverage    94.95%   94.95%           
========================================
  Files           33       33           
  Lines         1408     1408           
========================================
  Hits          1337     1337           
  Misses          71       71           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@jacobcook1995 jacobcook1995 merged commit 2082a42 into develop May 17, 2023
@jacobcook1995 jacobcook1995 deleted the bugfix/pint_intersphinx_problem branch May 17, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants