Remove unnecessary critical messages in model.py scripts #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Critical logging messages were being raised by
Model
__init__
's when the errors they were emitting were being handled by higher level functions inmain.py
. This is obviously not correct, as it led to multipleCRITICAL
messages being logged. I thought it was worth fixing this immediately as the documentation informing people how to setup a model was basically instructing people to make this mistake.This does not fix #113 or #160, which are much broader discussion. It does however remove an egregious example of the problem.
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks