Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to fix isort issue in pre-commit #156

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Conversation

davidorme
Copy link
Collaborator

Description

Something about poetry has resulted in changes to isort that broke a bunch of things. The newest version fixes those and so this PR just updates our pre-commit, pyproject.toml and poetry.lock to isort 5.12.0.

See here:

PyCQA/isort#2083

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@davidorme davidorme changed the title Dorme isort patch Patch to fix isort issue in pre-commit Jan 30, 2023
Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidorme davidorme merged commit 4828353 into develop Jan 30, 2023
@davidorme davidorme deleted the dorme-isort-patch branch January 30, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants