Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #123

Merged
merged 2 commits into from
Dec 2, 2022
Merged

[pre-commit.ci] pre-commit autoupdate #123

merged 2 commits into from
Dec 2, 2022

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Nov 28, 2022

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
ce43c87 
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0)
- [github.com/PyCQA/flake8: 5.0.4 → 6.0.0](PyCQA/flake8@5.0.4...6.0.0)
@jacobcook1995
Copy link
Collaborator

For some reason flake8 no longer seems to like comments within the extend-ignore block (found in setup.cfg), which we have here.

It generates they following error ValueError: Error code '#' supplied to 'extend-ignore' option does not match '^[A-Z]{1,3}[0-9]{0,3}$'.

Not sure if this is intended flake8 behaviour or not

@jacobcook1995
Copy link
Collaborator

jacobcook1995 commented Nov 29, 2022 •
edited
Loading

Apparently the way we added comments within extend-ignore was always incorrect, but with the recent flake8 update the problem is now caught

davidorme
davidorme approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobcook1995 jacobcook1995 merged commit 89407ed into develop Dec 2, 2022
@jacobcook1995 jacobcook1995 deleted the pre-commit-ci-update-config branch December 2, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidorme davidorme davidorme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobcook1995 @davidorme