Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update body and wake FoR multiplication #309

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

kccwing
Copy link
Collaborator

@kccwing kccwing commented Dec 9, 2024

silly mistake really - position in Gframe of multibody is offset by cga_0 not cga(t)

silly mistake really - position in Gframe of multibody is offset by cga_0 not cga(t)
@ben-l-p
Copy link
Collaborator

ben-l-p commented Jan 24, 2025

Apologies for taking so long to getting around to looking at this PR - this is an issue I was facing, so thank you for the fix. Should the time step you index not be the current one self.data.structure.timestep_info[self.ts].cga(), rather than the initial time stepself.data.structure.timestep_info[0].cga()?

@kccwing
Copy link
Collaborator Author

kccwing commented Jan 24, 2025

Thanks @ben-l-p, no worries! The trouble here is that the multibody solver, unlike the standard structural solver, stores in timestep_info['pos'] the displacements in the A frame, rather than in G - this is a patch to correct for that. Ideally this should have been done in the solver structure I agree - but the code uses the position too often so this is a "cleaner" patch.

@kccwing
Copy link
Collaborator Author

kccwing commented Jan 24, 2025

ah sorry, I think I didn't answer your question - so basically the position is correct - it is just forgetting the initial FoR change.

@ben-l-p
Copy link
Collaborator

ben-l-p commented Jan 27, 2025

Okay, that makes sense. Will approve it now, however will merge once we add a patch for the Mayavi issues, which I will investigate today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants