Fix geometries #96
Merged
Fix geometries #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheginit
reviewed
Mar 22, 2024
cheginit
reviewed
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OSM graphs often have geometries in the wrong direction (e.g., direction of
LineStringgoes from end node to start node). I don't think this has much impact, but visually is confusing. I suppose it is conceiveable it could mess withsplit_long_edges.The snap parameter of PySheds I think should just be set to >= 0, as in the context of many overlapping sewersheds, I don't think it makes sense to snap to a high accumulation point
This PR does a basic fix on these.