-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended demo #318
Extended demo #318
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
fiddling
for more information, see https://pre-commit.ci
couple more edits
fix links
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still getting the same OGR messages and complain about IProgress, but I it all looks good to me. The plotting comment can probably be extracted as separate issues to tackle in the future.
See:
|
for more information, see https://pre-commit.ci
Description
verbose
call is really massive for a demo - so I've tried to wrap it in a scrollable jupyter output. It doesn't look amazing, but I've tried quite a few things and this is the best I can do (without adding in a bunch of html stuff into the demo, which is probably confusing)!planetary_computer
seems to be down #316 . I guess I couldaddress_overrides
forelevation.tif
to ensure it is reliable. I could provide all the downloads in fact, but then this does make the example aroundallowable_networks
a bit complex (as that forces a re-download) and move this further away from a real use case. If we're mocking a bunch of stuff we should probably align that with mock downloads ontest_swmmanywhere.py::test_swmmanywhere
#214 and maybe Use VCR for testing #257 . That said this all sounds like a lot to do. I plan to redo the actions next week hopefully whenplanetary_computer
seems to be down #316 is working.Fixes #308
Fixes #106
Fixes #265
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks