Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended demo #318

Merged
merged 43 commits into from
Oct 23, 2024
Merged

Extended demo #318

merged 43 commits into from
Oct 23, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Oct 18, 2024

Description

  • A more comprehensive demo notebook
  • The output of a verbose call is really massive for a demo - so I've tried to wrap it in a scrollable jupyter output. It doesn't look amazing, but I've tried quite a few things and this is the best I can do (without adding in a bunch of html stuff into the demo, which is probably confusing)!
  • It's currently struggling on tests because of planetary_computer seems to be down #316 . I guess I could address_overrides for elevation.tif to ensure it is reliable. I could provide all the downloads in fact, but then this does make the example around allowable_networks a bit complex (as that forces a re-download) and move this further away from a real use case. If we're mocking a bunch of stuff we should probably align that with mock downloads on test_swmmanywhere.py::test_swmmanywhere #214 and maybe Use VCR for testing #257 . That said this all sounds like a lot to do. I plan to redo the actions next week hopefully when planetary_computer seems to be down #316 is working.
  • I also need to update the parameters a bit and maybe broaden the bounding box since the results look pretty odd

Fixes #308
Fixes #106
Fixes #265

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@github-actions github-actions bot enabled auto-merge October 18, 2024 11:21
@barneydobson barneydobson disabled auto-merge October 18, 2024 15:35
@github-actions github-actions bot enabled auto-merge October 21, 2024 11:35
@barneydobson barneydobson mentioned this pull request Oct 21, 2024
@github-actions github-actions bot enabled auto-merge October 22, 2024 10:45
@barneydobson barneydobson disabled auto-merge October 22, 2024 11:11
@barneydobson barneydobson requested a review from dalonsoa October 22, 2024 18:20
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting the same OGR messages and complain about IProgress, but I it all looks good to me. The plotting comment can probably be extracted as separate issues to tackle in the future.

src/swmmanywhere/utilities.py Show resolved Hide resolved
docs/notebooks/extended_demo.py Show resolved Hide resolved
@barneydobson
Copy link
Collaborator Author

I'm still getting the same OGR messages and complain about IProgress, but I it all looks good to me. The plotting comment can probably be extracted as separate issues to tackle in the future.

See:

OK this is a gpd.read_file issue. I can't figure out how to log it, suppress it, filter it, or anything that is a good idea. (I was able to suppress it in ipython, but it didn't seem to work in jupyter for whatever reason).

I could either write my own geojson reader (no thanks), but I am expecting this entire module (synthetic_write in post_processing.py) to be massively refactored following #84 anyway.

Thus I propose for now we ignore it.

@barneydobson barneydobson merged commit fd8b497 into main Oct 23, 2024
5 checks passed
@barneydobson barneydobson deleted the extended-demo branch October 23, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowable_networks changes should re-create street osmnx warning Notebooks
3 participants