generated from ImperialCollegeLondon/pip-tools-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move packages within src and fix extra things #295
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b685172
Move packages within src and fix extra things
dalonsoa fe9f0e9
run pre-commit
barneydobson d717adb
Run pre-commit again
dalonsoa 1e07690
Try fix namespace thing
barneydobson 87c5c3b
Revert "Try fix namespace thing"
barneydobson 6ec6add
Merge branch 'use_src' of https://github.com/ImperialCollegeLondon/SW…
barneydobson 3688c9a
try to fix namespce thing
barneydobson c5d911a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a4f9fa6
Tweak coverage config and build
dalonsoa 8337df3
add licence
f74a76e
Merge branch 'main' into use_src
d610787
run pre-commit on new machine
cb5623e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 460749f
attempt to fix isort
035ef67
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f000198
correct konwn first party
e86d656
Merge branch 'use_src' of https://github.com/ImperialCollegeLondon/SW…
76f320d
run preommit
66da2ed
revert because not sure
60c94f8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c01f008
try tahers suggestion again
5bb9622
Merge branch 'use_src' of https://github.com/ImperialCollegeLondon/SW…
659e8d4
run pre commit
c7d5f03
remove old attempt to fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
- Loading branch information
commit c5d911adb7a0b1a5938f2d603fb05a2bc00dd4e2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
from __future__ import annotations | ||
|
||
import networkx as nx | ||
|
||
from swmmanywhere.metric_utilities import metrics | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be down with the
swmmanywhere
imports no?ruff
is moving this inpre-commit
on my machine back down toswmmanywhere
butprecommit.ci
is moving it back on here... @cheginit do you have any ideas here as @dalonsoa is unavailable at the moThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be for the
import netcomp
lineThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this about
isort
? If so, you need to specify what are the first-party packages.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't include
src
, just the name of the package. The pre-commit error sounds like an issue with the service.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - shall I just abandon
precommit.ci
and return it to what we had previously for now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh lol it has passed now - maybe was a one off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it sometimes happens, so don't sweat it 😄