Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove api keys/new elevation downloader #222

Merged
merged 7 commits into from
Jun 18, 2024
Merged

remove api keys/new elevation downloader #222

merged 7 commits into from
Jun 18, 2024

Conversation

barneydobson
Copy link
Collaborator

Description

NASADEM can be downloaded without API keys (thanks @cheginit ) - now no need for API keys at all!

Fixes #94

@barneydobson barneydobson linked an issue Jun 17, 2024 that may be closed by this pull request
@barneydobson barneydobson requested review from dalonsoa and cheginit and removed request for dalonsoa June 17, 2024 13:54
swmmanywhere/prepare_data.py Outdated Show resolved Hide resolved
swmmanywhere/prepare_data.py Outdated Show resolved Hide resolved
swmmanywhere/prepare_data.py Outdated Show resolved Hide resolved
swmmanywhere/swmmanywhere.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping aside agreeing with @cheginit comments, and a suggestion for the test, this looks good. Not needing API keys always makes things simpler.

tests/test_prepare_data.py Outdated Show resolved Hide resolved
@barneydobson barneydobson merged commit 6d3eb64 into main Jun 18, 2024
8 checks passed
@barneydobson barneydobson deleted the nasadem-noapi branch June 18, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API keys via env variables
3 participants